Conversation
ejona86
added
the
TODO:release blocker
The prior uniform shuffle in pick_first will send uniform load across clients. When endpoints have weights, we'd desire for endpoints to be selected proportionally to their weight. The server weight attribute has to move out of xDS to be seen by pick-first, but it is kept as internal for now. Since xDS is the only thing that sets weights, the behavior change is only visible to xDS. See gRFC A113
ejona86
force-pushed
the
pf-weighted-shuffle
branch
from
78a0f8f to
338846f
Compare
|
The force-push was me adding "gRFC A113" in a comment and in the commit descriptions. |
ejona86
added
the
TODO:backport
Previously, the number of endpoints in a locality would skew how much traffic was sent to that locality. Also, if endpoints in localities had wildly different weights, that would impact cross-locality weighting. For example, consider: LocalityA weight=1 endpointWeights=[100, 100, 100, 100] LocalityB weight=1 endpointWeights=[1] The endpoint in LocalityB should have an endpoint weight that is half the total sum of endpoint weights, in order to receive half the traffic. But the multiple endpoints in LocalityA would cause it to get 4x the traffic and the endpoint weights in LocalityA causes them to get 100x the traffic. See gRFC A113
ejona86
force-pushed
the
pf-weighted-shuffle
branch
from
338846f to
4305786
Compare
|
Aaand that force-push changed |
ejona86
removed
the
TODO:backport
kannanjgithub
removed
the
TODO:release blocker
|
@kannanjgithub,
Not much to do about it now, since 1.79.0 has been released. |
|
My mistake by oversight, sorry about that. The striking out of the "gRFC hasn't been created yet" made me think the gRFC had been merged even though only the PR had been out. |
3 participants
There's two commits here with descriptions in each; take a look at each individually and I'll keep them separate when merging.
There will be a gRFC for this, but apparently it hasn't been created yet(gRFC A113 grpc/proposal#535) and I didn't want to wait longer for it to be created before starting review, because the plan is to delay the 1.79.0 release for this in Java and Go. We will want to merge this ASAP (and backport at our convenience), but we must wait until the gRFC is merged before publishing the 1.79.0 release. I suggest we leaveTODO:release blockerlabel here until the gRFC is merged. (Kannan, I shared a doc and an email thread with you to give you some context; mostly for what problem is being solved, and not the specific solution here. The specific solution here is split across a lot of comments, so you're best off waiting for the gRFC to see something documenting it.)While doing this I've noticed lots of things to fix with how weights are handled. I've basically ignored them at the moment, only trying to make sure that I don't make things worse. I'll be doing a follow-up to fix more weight handling, but I will not be trying to backport it.